Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyspace: set keyspace name by env #53294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented May 15, 2024

What problem does this PR solve?

Issue Number: ref #53296

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Start PD and TiKV servers.
  2. set env:
export KEYSPACE_NAME="ks1"
  1. start TiDB server:
    We can see log:
["using API V2."] [keyspaceName=ks1]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shenli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
Copy link

tiprow bot commented May 15, 2024

Hi @ystaticy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5473%. Comparing base (f0af776) to head (b7aa8e8).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53294        +/-   ##
================================================
+ Coverage   74.3523%   74.5473%   +0.1949%     
================================================
  Files          1494       1494                
  Lines        356302     429822     +73520     
================================================
+ Hits         264919     320421     +55502     
- Misses        72035      89468     +17433     
- Partials      19348      19933       +585     
Flag Coverage Δ
integration 49.0803% <62.5000%> (?)
unit 71.2612% <100.0000%> (-1.8450%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.4484% <ø> (+7.4815%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant