ddl: add owner_id field to tidb_mdl_info to avoid unexpected writes (#53234)

[ti-chi-bot]

This is an automated cherry-pick of #53234

What problem does this PR solve?

Issue Number: close #53073

Problem Summary:

tidb-1 keeps printing "someone is not synced", which means it is blocked at waitSchemaSynced.

[2024/05/13 17:24:32.067 +08:00] [INFO] [syncer.go:352] ["syncer check all versions, someone is not synced"] [category=ddl] [info="instance ip tc-tidb-1.tc-tidb-peer.endless-ha-test-add-index-tps-7576420-1-811.svc, port 4000, id d3ac6d21-0137-4106-b42a-89692b7ba7e1"] ["ddl job id"=791] [ver=1931]

tidb-1 is DDL owner. However, tidb-1's schema version is less than non-owner TiDB (here are the results from tiup ctl:v8.0.0 etcd --endpoints={pd_addr}:2379 get --prefix /tidb/ddl):

/tidb/ddl/all_schema_by_job_versions/791/5bd21551-75b9-4a47-86d4-9520ce74cfd3
1931
/tidb/ddl/all_schema_by_job_versions/791/d3ac6d21-0137-4106-b42a-89692b7ba7e1
1930
...
/tidb/ddl/fg/owner/66018f542345e63b
d3ac6d21-0137-4106-b42a-89692b7ba7e1

After checking the log, I found that DDL owner is switched from tidb-0 to tidb-1 at this time.

On the other hand, mysql.tidb_mdl_info is empty.

Above all, the timeline should be:

1. tidb-0 gets owner
2. tidb-0 registers mdl info
3. tidb-0 waits schema sync

4. tidb-1 gets owner from tidb-0

5. tidb-1 register mdl info
6. tidb-0 clean mdl info
7. tidb-1 wait schema sync, block...

At step 6, tidb-0 incorrectly clean the mdl info registered by tidb-1. As a result, there is nothing to update in mdlCheckLoop because tidb_mdl_info is empty.

What changed and how does it work?

• Add owner_id field to tidb_mdl_info to identify which owner is used.
• Prevent updating unexpected mdl info by specifying owner_id in WHERE clause.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
  With this PR, we can pass the test mentioned in issue add index blocked due to tidb schema version can not sync and caused that other ddl job always queueing after injection pd leader io delay #53073.
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-15 13:24:23.728042787 +0000 UTC m=+1659617.485178358: ☑️ agreed by tangenta.
• 2024-05-15 13:25:43.695758592 +0000 UTC m=+1659697.452894164: ☑️ agreed by YuJuncen.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@cefc9ec). Click here to learn what that means.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.1     #53300   +/-   ##
================================================
  Coverage               ?   71.1782%           
================================================
  Files                  ?       1465           
  Lines                  ?     421230           
  Branches               ?          0           
================================================
  Hits                   ?     299824           
  Misses                 ?     100940           
  Partials               ?      20466           

Flag	Coverage Δ
unit	71.1782% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	40.9873% <0.0000%> (?)

[tangenta]

/retest

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YuJuncen,tangenta]
• br/OWNERS [YuJuncen]
• pkg/ddl/OWNERS [tangenta]
• pkg/session/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment