Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]GC: support BR,Lightning,Dumpling update Service SafePoint with GCManagementType #53303

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented May 15, 2024

What problem does this PR solve?

GC: support BR,Lightning,Dumpling update Service SafePoint with GCManagementType

Issue Number: ref #53379

Problem Summary:

What changed and how does it work?

  1. create keyspace and enable keyspace level GC:
  2. start TiDB with keyspace-name=ks1
  3. Run BR backup and restore command with --keyspace-name=ks1
  4. check BR log, expect to see:
update keyspace level service safe point.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…ateServiceGCSafePoint

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none component/dumpling This is related to Dumpling of TiDB. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2024
Copy link

tiprow bot commented May 15, 2024

Hi @ystaticy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ystaticy ystaticy changed the title use update Service SafePoint with GCManagementType GC: support update Service SafePoint with GCManagementType May 15, 2024
@ystaticy ystaticy changed the title GC: support update Service SafePoint with GCManagementType GC: support BR,Lightning,Dumpling update Service SafePoint with GCManagementType May 15, 2024
@ystaticy ystaticy changed the title GC: support BR,Lightning,Dumpling update Service SafePoint with GCManagementType [WIP]GC: support BR,Lightning,Dumpling update Service SafePoint with GCManagementType May 15, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 18.97810% with 111 lines in your changes are missing coverage. Please review.

Project coverage is 75.3398%. Comparing base (f0af776) to head (5cc212a).
Report is 31 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53303        +/-   ##
================================================
+ Coverage   74.3523%   75.3398%   +0.9874%     
================================================
  Files          1494       1519        +25     
  Lines        356302     440987     +84685     
================================================
+ Hits         264919     332239     +67320     
- Misses        72035      87480     +15445     
- Partials      19348      21268      +1920     
Flag Coverage Δ
integration 51.8531% <22.0339%> (?)
unit 71.2717% <15.9090%> (-1.8344%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.8092% <0.0000%> (-2.4879%) ⬇️
parser ∅ <ø> (∅)
br 60.7559% <19.6428%> (+17.7890%) ⬆️

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, leavrth for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Copy link

ti-chi-bot bot commented May 15, 2024

@ystaticy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 5cc212a link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented May 20, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant