Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS plank -initWithModelDictionary:error: assumes dictionary is dictionary #279

Open
bolsinga opened this issue Oct 15, 2020 · 0 comments
Open

iOS plank -initWithModelDictionary:error: assumes dictionary is dictionary #279

bolsinga opened this issue Oct 15, 2020 · 0 comments

Comments

@bolsinga
Copy link
Contributor

This is reading JSON data from the network. If the type behind a key changes, it is simple to crash models if casting is used to pass a non-dictionary in.

Trust but Verify.
bolsinga pushed a commit that referenced this issue Oct 19, 2020
Assert that modelDictionary is a NSDictionary when creating models
1d5ab20 
This may catch some bad casts in client code during development. This is basicallly a small first step towards #279.
@bolsinga bolsinga mentioned this issue Oct 19, 2020
Merged
bolsinga pushed a commit that referenced this issue Oct 20, 2020
Assert that modelDictionary is a NSDictionary when creating models (#281
8a9f34d 
)

This may catch some bad casts in client code during development. This is basically a small first step towards #279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bolsinga