Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that modelDictionary is a NSDictionary when creating models #281

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Assert that modelDictionary is a NSDictionary when creating models #281

merged 1 commit into from
Oct 20, 2020

Conversation

bolsinga
Copy link
Contributor

@bolsinga bolsinga commented Oct 19, 2020 •
edited
Loading

This may catch some bad casts in client code during development. This is basically a small first step towards #279.

Assert that modelDictionary is a NSDictionary when creating models
1d5ab20 
This may catch some bad casts in client code during development. This is basicallly a small first step towards #279.
woshimaliang
woshimaliang approved these changes Oct 19, 2020
View reviewed changes
Copy link

@woshimaliang woshimaliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@bolsinga bolsinga merged commit 8a9f34d into master Oct 20, 2020
@bolsinga bolsinga deleted the TrustButVerify branch October 20, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

@woshimaliang woshimaliang woshimaliang approved these changes

@jparise jparise Awaiting requested review from jparise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bolsinga @garrettmoon @woshimaliang