Skip to content

Commit

Permalink
In reference to 7ed5273 to resolve #93 the conflicting "start" even…
Browse files Browse the repository at this point in the history
…t has been renamed to `"setup"` and the former `"setup"` became a private function `setup()` instead of a handler callback.

Not the handler, but mere triggering of `"start"` was causing the problems, hence a backward compatible trigger can not happen (sorry for that) and all user applications binding `"start"` need to be updated to bind `"setup"` instead.
  • Loading branch information
pisi committed Feb 27, 2012
1 parent bb74270 commit 0363867
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.markdown
@@ -1,6 +1,9 @@
Changelog
=========

* Patches incompatibility issues with jQuery 1.7 in IE (GH-93).


Version 1.1.3
-------------

Expand Down
10 changes: 5 additions & 5 deletions jquery.reel.js
Expand Up @@ -148,8 +148,7 @@ jQuery.reel || (function($, window, document, undefined){
},

// Events & handlers
on= {
setup: function(e){
setup= function(e){
/*
- fills up the data storage with values based on options
- binds to ticker
Expand Down Expand Up @@ -206,8 +205,9 @@ jQuery.reel || (function($, window, document, undefined){
});
pool.bind(_tick_, on.tick);
cleanup.call(e);
t.trigger('start');
t.trigger('setup');
},
on= {
teardown: function(e){
/*
- unbinds events, erases all state data
Expand Down Expand Up @@ -239,7 +239,7 @@ jQuery.reel || (function($, window, document, undefined){
.unbind(_mouseup_).unbind(_mousemove_);
cleanup.call(e);
},
start: function(e){
setup: function(e){
/*
- binds all mouse/touch events (namespaced)
- prepares stage overlay elements
Expand Down Expand Up @@ -656,7 +656,7 @@ jQuery.reel || (function($, window, document, undefined){
},
slidable= true,
stage_pool= $.browser.opera ? pool : $.unique(pool.add(window.top.document))
on.setup();
setup();
});

ticker= ticker || (function tick(){
Expand Down

0 comments on commit 0363867

Please sign in to comment.