New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reel blinking in Firefox #196
Comments
Have crappy connection at the moment, but from a brief look, I would say the images are far too big for Firefox to render them in time. Hence the blinking. I can not even load them all.. Will do some measurements once my connection is back in shape. |
Hello! Just following up on this. We've had this problem only in Firefox but no other browsers, so it seems like it must be specifically related to how Firefox is loading either (or both) the script and images vs. Chrome, IE, etc. Today I added a 6 second delay to see if it would help give more time for the images to load, but it still flickers: http://s3.amazonaws.com/LLShop/reel/CLASSIC-O-O-BIG.html I realize that one is large. Here is a much smaller version of the same reel, each file is about 1/10th of the size. The flicker still occurs: http://s3.amazonaws.com/LLShop/reel/CLASSIC-O-O.html I absolutely love this script. Any help would be appreciated, thanks! |
I'm still at a loss on this - any help would be appreciated ~ thanks! |
Just a short one (no time :( ) I toy with it for a while now and I still have no clear idea what might be causing this, but I noticed few things:
|
Thanks! Thanks Petr, I just did some testing to see if changing any of the above would help.
http://s3.amazonaws.com/LLShop/reel/CLASSIC-O-O-BIG.html
Still seeing flickers. :( |
From what I can tell Firefox renderer simply can not keep up with the tempo and partial aborts with added queueing is the result. When I for example let it run and flicker for a while, I wasn't then even able to log anything into console unless I stopped the Reel animation. Even though the renderer was still clearly heavily queued, the stop happened instantly leading me to believe, that it is not Javascript choking and queueing, but the renderer itself. Which is a good thing I think. You see, your BIG images really are far too huge for poor Firefox's slice of CPU power to draw them in time. So let's try to employ the GPU instead. I patched the code to enable hardware acceleration on the image in Firefox and so far it looks good even with Please try using this jquery.reel.js to see if it helps. Fingers crossed. |
Thank you Petr, I've changed the reel to the one in your link above on the following two examples (linked again here to make it easy). http://s3.amazonaws.com/LLShop/reel/CLASSIC-O-O-BIG.html Sadly, it seems to have helped the smaller version a little but hasn't gotten rid of the flickering. |
P.S. - I'm reloading it a bunch right now and it ONLY seems to be doing the flickering on the first spin. After that it's working perfectly. After that, it's loading fine. Also, using this script version seems to make the script working entirely in IE and Chrome for me. |
Just following up on this issue. Thanks! |
Same here, our reels are not nearly as large as @lifeinlightspeed is using but we still get the flicker in Firefox as well. |
Sadly, this issue seems to be a combination of several different factors, which makes it hard to spot a common ground. @kzurawel Can you show me your Reel(s)? |
@pisi Sure, here is one of them: http://www.nissancommercialvehicles.com/nv-cargo/gallery It only seems to have flickering issues in Firefox (both Mac and Windows). |
Since the hardware acceleration had some positive outcome, I guess there's no harm in merging that into the development branch and into the next release. Sadly, I still have no clear clue about the blinking :/ |
We are using HD images and experience the same (in that case even stronger) effect. Fix is much appreciated, although I know, that this one is probably rather to be solved by mozilla. Best regards |
From the above linked #231. New observations from testing in Firefox (23.0.1 on OSX 10.6.8):
|
Thanks for the quick reply and the suggestions. Since these images are supposed to be in such a high resolution for a scientific project, we cannot reduce the image quality. Once the project is published, I may provide a URL here. We will just use it as it is and wait for technical improvements of FireFox. |
Alright. There is a solution to this issue. At least it did work out with the previously mentioned reel. This reel displays a sequence of 100 images, each with dimensions of 1920px height and 1080 px width. Realizing that FireFox is able to display the images properly when debugging with the 'Inspector Tool' via right click and 'Inspect Element', I assumed that FireFox has the capability to display high resolution images within the reel and therefore I did append .reel-cached {
display: block !important;
} to the css declarations. This overrides the default If this solution is confirmed by others, it is maybe worth setting the display style for reels running in FireFox accordingly by default or providing an additional option to allow developers to choose whether they prefer the 'preloaded' images to be set visible or invisible. With best regards Martin |
The images are visible then and you may position them somewhere outside of the window area with some additional css declarations. FireFox will keep them loaded and display them without any flashing. .reel-cached {
display: block !important;
position: fixed;
bottom: -10000px;
} |
Yes, this makes the preloaded images visible. This approach is indeed interesting, because in the next version, these cached images won't be present in the DOM anymore and will instead become pure in-memory-only Image instances. But seeing this I may have to revert this and do offscreen instead of invisible like you do. I'm thrilled to see somebody confirm this. @MartinPluta, can you please try the soon to be released 1.3 RC over there in the development branch - this doesn't have these cached DOM nodes. I'm really curious whether this will make some difference for you. Thanks! |
Sure, I will try to do this throughout the weekend and drop a comment here as soon as I have some results. Thanks for the link to the development branch. Best regards Martin |
Interesting; I'll try this as well and report back with what happens. On Fri, Sep 27, 2013 at 7:48 AM, Martin Pluta notifications@github.comwrote:
J. Adam LefeverTwitter http://www.twitter.com/adamlefever - Adamlefever.com http://www.adamlefever.com"...the man who really counts in the world is the doer, not the mere
|
The current development version produces the same issue, which could not be solved with any additional CSS declaration. Possibly, you find another solution or some working CSS declaration. Before making any plans for changes in the development, I recommend that you perform further testing. If there s any way I can support you, just let me know. Best regards Martin |
I tried both the edge version of reel and reel 1.2. I too can confirm the css solution no longer works on the edge version. The image flickering issue started with Firefox 21 and it is also present in Firefox Aurora (v 26). |
That's what I thought, but the memory only image caching was worth a shot ;) Sadly it looks like renderer needs to cache these, so I put the cache container back in the DOM with visible images shifted out of sight far up left inspired by the workaround by @MartinPluta. Guys, please test out the reborn gh-196-firefox-flicker branch for me please. Fingers crossed. I'd very much like to hide these images if possible - render them visible inside, but inside a hidden container - so I backed in an option to test this too. |
Thanks for the effort. I will give it a try on the weekend I guess. Meanwhile, I was working to get the reel running with www.leapmotion.com . Think this will probably be in some notebooks in the near future and its worth to check it out. As soon as I have managed to get it running with gesture control (it already runs somehow but requires some improvements), I will let you know. I'll give some feedback on the firefox branch by next week. |
That's super awesome! I'm thrilled to see Leap to make it into production. Can't wait. Thank you, Martin. |
I managed to put together an example using images and options from nissancommercialvehicles link here in the thread. This link does flicker for me in Firefox 24 on OSX, so I was off exploring solutions. Will put the example and updated code online later today, but here's what I tried and saw:
So points 2 and 3 combined looks like our solution, folks! |
OK, so here's jsfiddle to reproduce the flickering. During the 1 second opening animation and also during the initial phases of hand dragging, it does flicker in the bottom are of the images right where the wheels and shadow are. The flickering goes away after a little while as renderer caches these images. And here's an updated fiddle with flickering cured. Now the code pre-caches images for renderer, which ceases the flicker. Whoever can, visit these links with Firefox and verify the results for me please. |
Folks, a form of the CSS workaround has been implemented and will land in next release. I believe it will help :) If you'd like to test it out with your flickering setup, pick the development version. |
Dear friends, I have a great faith in the recently released v1.3rc that it will resolve this lengthy Firefox issue. Can someone please try it out and verify so that I can bump it? Thanks! |
Released today as part of v1.3.0 |
I tested the latest release and can still see the flickering issue in Firefox. The images are high-res (1920x1080). Can the previously mentioned css fix be applied as a workaround for now? |
I am still having the flicker issue as well. There was a period of time that the flicker had stopped, but it seems to be more difficult to resolve than previously thought. |
The problem exists when FF's hardware acceleration is enabled, which is by default. Not sure if there is a way around it programmatically. |
I've been testing reel for various 360 reels and set up a bunch of them in the past month for a project.
They were all working wonderfully but sometime in the past couple weeks they started blinking in Firefox once the reel loads and the spins begin (I'm running FF v.21). This same problem isn't persisting in IE or Chrome.
Example: http://s3.amazonaws.com/LLShop/reel/SABRINA-S-B-BIG.html
Any assistance would be appreciated - thank you...!
The text was updated successfully, but these errors were encountered: