Skip to content

Commit

Permalink
*5557* edit_assignments table should be deleted in favor of workflow …
Browse files Browse the repository at this point in the history
…stage assignement table
  • Loading branch information
fgrandel committed Aug 31, 2010
1 parent 490aab7 commit ad149e1
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions classes/submission/editor/EditorSubmissionDAO.inc.php
Expand Up @@ -11,9 +11,9 @@
* @see EditorSubmission
*
* @brief Operations for retrieving and modifying EditorSubmission objects.
* FIXME #5557: We need a general code cleanup here (remove useless functions), and to integrate with monograph_stage_assignments table
*/

/* FIXME #5557: We need a general code cleanup here (remove useless functions), and to integrate with monograph_stage_assignments table */

import('classes.submission.editor.EditorSubmission');

Expand All @@ -34,7 +34,8 @@ function EditorSubmissionDAO() {
$this->monographDao =& DAORegistry::getDAO('MonographDAO');
$this->authorDao =& DAORegistry::getDAO('AuthorDAO');
$this->userDao =& DAORegistry::getDAO('UserDAO');
$this->editAssignmentDao =& DAORegistry::getDAO('EditAssignmentDAO');
// FIXME: Edit assignment DAO has been removed, see #5557.
//$this->editAssignmentDao =& DAORegistry::getDAO('EditAssignmentDAO');
}

/**
Expand Down Expand Up @@ -93,8 +94,9 @@ function &_returnEditorSubmissionFromRow(&$row) {
$this->monographDao->_monographFromRow($editorSubmission, $row);

// Editor Assignment
$editAssignments =& $this->editAssignmentDao->getByMonographId($row['monograph_id']);
$editorSubmission->setEditAssignments($editAssignments->toArray());
// FIXME: #5557 breaks this code.
// $editAssignments =& $this->editAssignmentDao->getByMonographId($row['monograph_id']);
// $editorSubmission->setEditAssignments($editAssignments->toArray());

// Editor Decisions
$reviewRoundsInfo =& $this->monographDao->getReviewRoundsInfoById($row['monograph_id']);
Expand Down

0 comments on commit ad149e1

Please sign in to comment.