Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last direct mentions of GL1 #6398

Merged
merged 3 commits into from
May 20, 2024
Merged

Remove last direct mentions of GL1 #6398

merged 3 commits into from
May 20, 2024

Conversation

mvaligursky
Copy link
Contributor

  • small cleanup

@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 10:34am

@mvaligursky mvaligursky self-assigned this May 20, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels May 20, 2024
@mvaligursky mvaligursky requested a review from a team May 20, 2024 09:58
@LeXXik
Copy link
Contributor

LeXXik commented May 20, 2024

Probably here too:

engine/README.md

Line 43 in 56d4ded

* 🧊 **Graphics** - Advanced 2D + 3D graphics engine built on WebGL 1 & 2.

slimbuck
slimbuck approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestions

README.md Outdated Show resolved Hide resolved
src/platform/graphics/webgl/webgl-graphics-device.js Outdated Show resolved Hide resolved
@mvaligursky @slimbuck
Apply suggestions from code review
0d7676b 
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
@mvaligursky mvaligursky merged commit 0869979 into main May 20, 2024
9 checks passed
@mvaligursky mvaligursky deleted the mv-gl1-remove branch May 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvaligursky @LeXXik @slimbuck