Explicitly upgrade pegdown's transitive parboiled-java dependency #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the whole thing work with Java 11+, thanks to a newer transitive ASM dependency
|
Alright, so this is failing because latest pegdown release does not support Java 8 anymore: sirthias/parboiled#195 Now... look at the pull request, it is necessary for support for Java 16+, but drops Java 8... |
|
Well, so I had to drop Java 8 now in this pull request (actually I already had prepared one 😉) |
Closed
30 tasks
|
Actually this will unblock a couple of other pull requests: So I will release a M1 of play-doc |
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the whole thing work with Java 11+, thanks to a newer transitive ASM dependency.
See explanation in #35 (comment)
(Actually I did test all of this locally, published play-docs and used it in play and started the play documentation, everything worked fine. So we are lucky.)