Java enum format #173
Java enum format #173
Conversation
|
Hi @tuxBurner, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
Hi @lightbend-cla-validator is signed the CLA |
| * | ||
| * @author Sebastian Hardt (s.hardt@micromata.de) | ||
| */ | ||
| object JavaEnumFormat { |
There was a problem hiding this comment.
With not with other default? (Take care about @author vs CLA)
There was a problem hiding this comment.
Sorry about this will remove it :)
| @@ -0,0 +1,6 @@ | |||
| package play.api.libs.json | |||
|
|
|||
| object JavaTestsEnumsFormat { | |||
There was a problem hiding this comment.
What do you mean ?
I looked how the other enum tests are working
"EnumFormat" should {
import TestEnums.EnumWithCustomNames._
There was a problem hiding this comment.
There is no need to have a separate file, whereas there are existings file for format tests
|
is anyone interested in pursuing this further, or should we just close it for inactivity? |
Pull Request Checklist
Fixes
Doesn't have a ticket
Purpose
Often I have or use java enums in my projects and have to serialize or deserialize them in json context.
So i wrote a generic solution for doing this and want give it back to the comunity.
Background Context
Because i got sick of duplicating code :)
References
Are there any relevant issues / PRs / mailing lists discussions?