Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #700 - Safe Json.parse alternatives #987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Close #700 - Safe Json.parse alternatives #987

wants to merge 1 commit into from

Conversation

cchantep
Copy link
Member

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #700

@mkurz
Copy link
Member

mkurz commented Mar 12, 2024

@cchantep Binary Compatibility checks fail, so probably this has to wait for play-json 3.1.0 (?)

cchantep
cchantep commented May 20, 2024
View reviewed changes
build.sbt
mimaBinaryIssueFilters ++= Seq(
),
mimaBinaryIssueFilters ++= {
val missingMethodInOld: ProblemFilter = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new feature doesn't break backward compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a JSON parsing API that returns Try or similar type instead of throwing exception
2 participants
@cchantep @mkurz