Merge pull request #3536 from plentymarkets/fix/requested_url

remove parameters from requestedVariationUrl
plentymarkets · Apr 11, 2024 · d6b1fd8 · d6b1fd8
2 parents 82dc97f + 2e74bfb
commit d6b1fd8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/meta/documents/changelog_de.md b/meta/documents/changelog_de.md
@@ -9,6 +9,7 @@
     - Im Zuge dieses Fixes wurde eine [MIME-Type libary](https://www.npmjs.com/package/mime-types) eingebunden. 
 - Die Einstellung: **Hake die Artikelinformationen an, die du in der Warenkorbvorschau anzeigen möchtest.** im plentyShop Assistenten Schritt **Angezeigte Informationen** hatte keine Auswirkung auf die angezeigten Informationen. Dies wurde behoben.
 - Durch das Fixieren des Headers zum Verbessern der CLS-Werte kam es unter Umständen zu einem ungewünschten Scroll-Verhalten beim Browsen des Shops. Dies wurde behoben.
+- Die Variable "requestedVariationUrl" gibt nun die URL ohne Query-Parameter zurück.
 
 ### Geändert
 

diff --git a/meta/documents/changelog_en.md b/meta/documents/changelog_en.md
@@ -9,6 +9,7 @@
     - As part of this fix, a [MIME-Type libary](https://www.npmjs.com/package/mime-types) was integrated. 
 - The setting: **Check the boxes of the item information you want to display in the shopping cart preview** in the plentyShop assistant step **Displayed information** had no effect on the information displayed. This has been fixed.
 - Fixing the header to improve CLS values sometimes caused undesired scroll behaviour when browing the shop. This has been fixed.
+- The variable "requestedVariationUrl" now returns the URL without query parameters.
 
 ### Changed
 

diff --git a/src/Contexts/SingleItemContext.php b/src/Contexts/SingleItemContext.php
@@ -2,14 +2,14 @@
 
 namespace Ceres\Contexts;
 
-use IO\Helper\Utils;
 use IO\Helper\ContextInterface;
+use IO\Helper\Utils;
 use IO\Services\CategoryService;
 use IO\Services\CustomerService;
+use Plenty\Modules\Category\Models\Category;
+use Plenty\Modules\Webshop\Contracts\ContactRepositoryContract;
 use Plenty\Modules\Webshop\Helpers\UrlQuery;
 use Plenty\Plugin\ConfigRepository;
-use Plenty\Modules\Webshop\Contracts\ContactRepositoryContract;
-use Plenty\Modules\Category\Models\Category;
 
 /**
  * Class SingleItemContext
@@ -312,7 +312,8 @@ public function init($params)
         $this->setAttributeMap = $params['setAttributeMap'];
         /** @var UrlQuery $urlQuery */
         $urlQuery = pluginApp(UrlQuery::class, ['path' => $this->request->getRequestUri(), 'lang' => Utils::getLang()]);
-        $this->requestedVariationUrl = $urlQuery->toAbsoluteUrl(Utils::getLang() !== $this->webstoreConfig->defaultLanguage);
+        $urlWithParameters = $urlQuery->toAbsoluteUrl(Utils::getLang() !== $this->webstoreConfig->defaultLanguage);
+        $this->requestedVariationUrl = explode("?", $urlWithParameters)[0] ?? '';
         $defaultCategoryId = 0;
         $plentyId = Utils::getPlentyId();
         foreach ($this->item['documents'][0]['data']['defaultCategories'] as $category) {