Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on CMFUid. #1608

Closed
wants to merge 1 commit into from
Closed

Remove dependency on CMFUid. #1608

wants to merge 1 commit into from

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented May 28, 2016

Seems unused. Let the tests decide.

@jensens
Copy link
Sponsor Member Author

jensens commented May 28, 2016

see also #1343

@gforcada
Copy link
Sponsor Contributor

At least needs an upgrade step and there are some traces of it in
cmfeditions
El dia 28/05/2016 6:46, "Jens W. Klein" notifications@github.com va
escriure:

see also #1343 #1343


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1608 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABGiYGMKVF1UdDMNX0H6M7js9_4aldw0ks5qF8ifgaJpZM4Io_fi
.

@gforcada
Copy link
Sponsor Contributor

I was looking into it, as the PLIP for collective.indexing got quite a lot of errors after rebasing my branch on top of CMFUid 2.3 instead of 2.2 and trying to clean CMFEditions from CMFUid traces lead me to portal_historyidhandler which is at least being used by plone.app.iterate.

I will stop here as that's a bit too much for a small cleanup, but it feels that CMFUid 2.3 branch is not ready at all and probably we stick with 2.2 and try to get rid of it instead of updating it.

I would need a separate PLIP though.

@jensens
Copy link
Sponsor Member Author

jensens commented May 30, 2016

Phew. CMFEditions should be changed to use plone.uuid. The tool in CMFEditions is deprecated anyway and can be removed. If anyone relies with addon code on CMFUid it can be installed anyway as an addon.

TODO:

  • make this a plip
  • Change CMFEditions to get its UIDs from plone.uuid (ensure old UUIDs are read)
  • Remove CMFEditions old deperecated BBB uid tool.
  • Conditional imports in plone.app.upgrade for CMFUid
  • Upgrade step in plone.app.upgrade to remove all traces of CMFUid

@jensens jensens closed this Feb 6, 2017
@jensens jensens deleted the remove-cmfuid branch February 6, 2017 17:48
@jensens jensens mentioned this pull request Feb 6, 2017
5 tasks
@jensens jensens removed this from Todo in Clean-up Tasks Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants