Fix ResourceRegistry in development mode #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensens
force-pushed
the
jensens-fix-rr-development
branch
from
e06b16e
to
4b30a9c
Compare
|
When sending the resource registry in development mode and activating the "develop javascript" mode on a bundle, I now get the following error in the console of the web browser: Can it be, that you somehow treat the non-legacy/compilable bundle resources like as if they were legacy resources? For legacy resources, |
|
^^ fixed in #1883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes a very annoying behavior of ResourceRegistry (RR) and some related issues. Developing JS and LESS/CSS on the file system and making this changes show up in Plone.
First sorry for mixing cleanup and changes. But it happened...
So this fix:
debug-mode(zope.conf, set viabuildout,cfginstance section): like with templates it does not deliver a production mode bundle, but always delivers a fresh bundle.debug-modedo not ignore development mode for anonymous users.bin/plone_compile_resourcesits just annoying if one has to reset the RR TTW.This PR refactors parts of the code. I do not expect anybody has subclassed the existing code, if so it may need minor adjustments. I do not consider this part of Plone as API.
Besides that all is as it was before, No upgrade step needed, nothing breaks.