Create coverage report in Travis. #102
Conversation
|
Travis is expected to fail, see a different pull request for the plone5 /plone.app.event stuff. |
|
Yes! The Plone 5 builds work and they pass info to coveralls. |
| - bin/test | ||
| - bin/createcoverage |
There was a problem hiding this comment.
I think createcoverage should run in the after_success sestion. This is not a test.
There was a problem hiding this comment.
Problem is that it then runs after bin/test-plone_addon, which leaves behind a test.plone_addon directory that the nosetests then also get run on, causing ImportErrors. Ah, but of course this directory only gets left behind when the command fails, so then there is no need to call createcoverage. I will move it.
In that case, we should move createcoverage in the generated package too. I will move that too.
|
@mauritsvanrees would you prefer to fix the Plone 4 build in this branch or shall we merge first? |
Generate nosetests script also under the 'test' name. Then bin/createcoverage works. In Travis call the new correct script names: - The new bin/test is the old bin/nosetests. - The new bin/test-plone_addon is the old bin/test. Created bin/alltests script. This runs bin/test, and the two test-plone_addon scripts. We could call that in Travis too. Added initial simple test to show coverage in hooks.py.
mauritsvanrees
force-pushed
the
maurits-coverage
branch
from
3ed96f2
to
780768e
Compare
|
Plone 4 fixes have been merged to master. |
|
Two minor changes added. Let me stop now. :-) |
|
Thanks so much @mauritsvanrees! Great work! Will do a release soon. |
Create coverage report in Travis.
This should solve issue #93, in a slightly different way than my last proposal there.
Generate nosetests script also under the 'test' name. Then
bin/createcoverage works.
In Travis call the new correct script names:
Created bin/alltests script. This runs bin/test, and the two
test-plone_addon scripts. We could call that in Travis too.
Added initial simple test to show coverage in hooks.py.