Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework whole Package to work under Python 2+3 and tests #206

Closed
wants to merge 34 commits into from
Closed

Rework whole Package to work under Python 2+3 and tests #206

wants to merge 34 commits into from

Conversation

loechel
Copy link
Member

@loechel loechel commented Jul 6, 2017

Rework the whole Package to make it testable and follow best practices.
Used tox and pytest as new test environment.

@coveralls
Copy link

coveralls commented Jul 6, 2017 •
edited

Coverage Status

Coverage increased (+28.8%) to 83.75% when pulling 83724b8 on tox into f5c2759 on master.

This was referenced Jul 6, 2017
Closed
Closed
loechel referenced this pull request in plone/plone_best_practices_discussion Jul 12, 2017
@loechel
Initial commit
25edefd
@coveralls
Copy link

coveralls commented Jul 15, 2017 •
edited

Coverage Status

Coverage increased (+43.1%) to 98.125% when pulling 71e8b1c on tox into f5c2759 on master.

@loechel
Copy link
Member Author

loechel commented Jul 15, 2017

@MrTango / @gforcada ready for you.

MrTango
MrTango reviewed Jul 18, 2017
View reviewed changes
tests/test_hooks.py Outdated
with pytest.raises(AttributeError):
hooks.validate_packagename(None)

configurator = Configurator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is here an indention missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. that is like it should.

I do test various variants within one test method.
As hooks.validate_packagename() should take a Configurator object but also tests against None did have for all of those case test steps. Maybe it would be good to put comments for each case.

@loechel
Copy link
Member Author

loechel commented Jul 18, 2017

@MrTango commented to make it clearer

@loechel
Copy link
Member Author

loechel commented Aug 10, 2017

Ok I have now moved the test matrix into the travis-ci config again.
It tests now all. but the fattheme test itself fail, could someone else please have a look.

@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Changes Unknown when pulling 133495b on tox into ** on master**.

@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Changes Unknown when pulling 5708c60 on tox into ** on master**.

3 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5708c60 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5708c60 on tox into ** on master**.

@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Changes Unknown when pulling 5708c60 on tox into ** on master**.

@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

5 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

@coveralls
Copy link

coveralls commented Aug 10, 2017 •
edited

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 04e5ac7 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

5 similar comments
@coveralls
Copy link

coveralls commented Aug 11, 2017 •
edited

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

@coveralls
Copy link

coveralls commented Aug 11, 2017 •
edited

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b6ace6 on tox into ** on master**.

@loechel
Copy link
Member Author

loechel commented Sep 14, 2017

this pull gets partial superseeded by #216

This was referenced Sep 14, 2017
Closed
Closed
@loechel
Copy link
Member Author

loechel commented Oct 3, 2017 •
edited

most of the stuff from this branch has already been merged into 3.0. so I close this pull request.

@loechel loechel closed this Oct 3, 2017
@jensens jensens deleted the tox branch March 2, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto tisto left review comments

@MrTango MrTango MrTango left review comments

@gforcada gforcada gforcada left review comments

@jensens jensens Awaiting requested review from jensens

@pbauer pbauer Awaiting requested review from pbauer

Assignees
No one assigned
Labels
04 type: enhancement 13 prio: normal 24 status: ready 32 needs: review 43 lvl: complex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@loechel @coveralls @MrTango @jensens @tisto @gforcada