New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove grok #962
Remove grok #962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, except the import should be one per line
from plone.supermodel import model | ||
from plone.directives import form | ||
|
||
from zope.component import queryUtility | ||
from zope.component import queryUtility,provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may you put the 2 imports on 2 lines please?
develop/plone/forms/vocabularies.rst
Outdated
from five import grok | ||
from zope.schema.interfaces import IContextSourceBinder | ||
from zope.component import provider | ||
from zope.schema.interfaces import IContextSourceBinder,implementer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Thanks! |
Fixes: #936
Changes proposed in this pull request:
These files were changed to remove grok
https://docs.plone.org/develop/addons/schema-driven-forms/customising-form-behaviour/vocabularies.html
https://docs.plone.org/develop/plone/forms/vocabularies.html
Comment :
I was looking at the code, how do i convert this part?