Theme filemanager searching feature fixes #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datakurre
commented
Jun 26, 2017
| @@ -189,7 +189,8 @@ define([ | |||
| findinFilesView.triggerView | |||
| ], | |||
| id: 'find', | |||
| app: self | |||
| app: self, | |||
| disable: function() {} | |||
There was a problem hiding this comment.
Disables disabling, because disabling "find" does not make sense in this context (other buttons may be disabled when the managed files are read only, but that does not prevent search).
datakurre
commented
Jun 26, 2017
| @@ -1,6 +1,6 @@ | |||
| @import "@{mockuplessPath}/ui.less"; | |||
| /* just be lazy here and include all of bootstrap... */ | |||
| @import "@{mockupPath}/filemanager/pattern.filemanager.less"; | |||
| @import "@{mockup-patterns-filemanager}"; | |||
There was a problem hiding this comment.
It's best practice in mockup to use the aliases when they exist to make it easier to override resources in build tools (and I needed this to override Plone default version with this in my webpack dev env).
There was a problem hiding this comment.
I just realised that this is a separate branch, I context switch and scanned through this. Yes, I agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@b4oshany Small issue. If the "edited" theme is readonly, find menu actions get disabled. (Code in thememapper patterns calls disable for all button groups.) Iterating through all buttons to only enable find-menu looked complex in themepattern, so I propose simply disabling "disable" from find menu component.