Hide content specific toolbar items on content view #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewWilkes
added
32 needs: review
24 status: ready
04 type: enhancement
23 status: testing
and removed
24 status: ready
labels
tisto
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
This has been unreviewed and unmerged way too long. IMHO we should do merge and release this for all Plone 5.x versions...Thanks @MatthewWilkes for the fix and PR!
|
Seems this PR leads to quite a few regressions. It also turned out that this is actually a bug in mockup... |
|
There was no activity on this for a while. I close this request for now. If you plan to work further on this please reopen and go on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes plone/Products.CMFPlone#1475 - a regression compared to Plone 4.