Set copy flags when copying container. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the _v_is_cp flag while the AT children were processed and thus the flag was not properly delegated. By copying the _v_is_cp and _v_cp_refs flags to the copy we have the same behavior as it used to be with AT, which does fix the error.
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
jone
added a commit
to 4teamwork/ftw.copymovepatches
that referenced
this pull request
Sep 1, 2016
**Problem:** When copying a DX container which has AT children, the UID of the AT children was not updated. The reason for the error is that the DX container copy did not have the `_v_is_cp` flag while the AT children were processed and thus the flag was not properly delegated. **Solution:** By copying the `_v_is_cp` and `_v_cp_refs flags` to the copy we have the same behavior as it used to be with AT, which does fix the error. - Issue: plone/Products.CMFPlone#1735 - Plone 4 fix: plone/plone.dexterity#60 - Plone 5 fix: plone/plone.dexterity#61
|
Sorry for the noise! Didn't expect that 😥 |
|
You can always start a Jenkins test-job on your own to test that your pull request (PR) does not break anything. Below click on the link to Jenkins log in with your Github user - if not already done before. Paste the full pull request URL into the text field (if multiple pull requests need to be combined in one run, then one PR URL per line) Click on Build Jenkins reports back to the pull request(s) on Github in the status box at the bottom. In Plone we value a lot our testing suite, so we usually never merge pull requests if they have not been tested by Jenkins first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master(Plone 5), see #60 for Plone 4Issue:
When copying a DX container which has AT children, the UID of the AT children was not updated.
The reason for the error is that the DX container copy did not have the _v_is_cp flag while the AT children were processed and thus the flag was not properly delegated.
Solution:
By copying the _v_is_cp and _v_cp_refs flags to the copy we have the same behavior as it used to be with AT, which does fix the error.
Closes plone/Products.CMFPlone#1735
Tests:
I could not reproduce the error in a test and therefore could not write a meaningful test. I'd appreciate inputs on how I can do that.
Though I have manually verified that this fix results in no longer having a broken UID index (see plone/Products.CMFPlone#1735 for details).
Plone Versions:
I have the problem on Plone 4.3.x. The PR is therefore pointing to plone.dexterity's
2.2.xbranch.Should I make a separate pull request target
masterfor Plone 5? Does not make sense to fix that for Plone 5 since Archetypes is no longer used there?