feat: support sandbox instances of salesforce #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharygolba
commented
Sep 24, 2019
| @@ -1,60 +0,0 @@ | |||
| import { Connection, OAuth2 } from "jsforce"; | |||
There was a problem hiding this comment.
This was split up into multiple files to make it easier to maintain in the future. Each file in the events directory now represents a single lambda event handler.
adampash
suggested changes
Sep 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 50% 49.35% -0.65%
==========================================
Files 11 11
Lines 304 308 +4
Branches 44 46 +2
==========================================
Hits 152 152
- Misses 152 156 +4
Continue to review full report at Codecov.
|
|
is this going to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Adds sandbox support by adding the ability to pass a
--sandbox(or-s, for short) flag to theglide initcommand. When--sandboxis passed to theinitcommand, a boolean"sandbox": trueproperty is added to the resulting json file. This option instructs the authentication layer of glide to use the correct login url (https://test.salesforce.com).Users of glide will be able to generate an additional json config for their sandbox instance by running the init command with the additional
[path]argument to specify the file name that best suits their projects naming conventions.To serve data from their sandbox instance rather than using the default production
glide.jsonfile, they can simply provide the filename as a positional argument to theservecommand.