Exporting files needed to execute zkevm-prover from starky. #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because generating it in Javascript is too slow.
lvella
changed the title
Merged
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Similar to #1193, but in here I am just interested in having it working end-to-end, at least for a few cases, so that everybody can try it and build upon. <!-- Please follow this protocol when creating or reviewing PRs in this repository: - Leave the PR as draft until review is required. - When reviewing a PR, every reviewer should assign themselves as soon as they start, so that other reviewers know the PR is covered. You should not be discouraged from reviewing a PR with assignees, but you will know it is not strictly needed. - Unless the PR is very small, help the reviewers by not making forced pushes, so that GitHub properly tracks what has been changed since the last review; use "merge" instead of "rebase". It can be squashed after approval. - Once the comments have been addressed, explicitly let the reviewer know the PR is ready again. --> --------- Co-authored-by: Leo <leo@powdrlabs.com>
|
@lvella is this still not working from the starky side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on hold while starky people investigates why the consttree.bin exported from starky is different from JS pil-stark.