Permutation example #1195
Draft
Permutation example #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
permutation_example
branch
from
87131b9
to
902a3a0
Compare
georgwiese
reviewed
Mar 25, 2024
| }; | ||
|
|
||
| let compress_selected_exprs: int, expr, expr, expr, expr[] -> expr = |id, alpha, beta, sel, exprs| | ||
| sel * (compress_columns(alpha, exprs) + id + beta - 1) + 1; |
There was a problem hiding this comment.
Where does the ID come from? We don't really need it, do we? I think it's a way to share the accumulator between several permutations, which we're not doing here?
chriseth
force-pushed
the
permutation_example
branch
from
902a3a0
to
1ec215f
Compare
georgwiese
reviewed
Mar 25, 2024
| }; | ||
|
|
||
| let compress_selected_exprs: expr, expr, expr, expr[] -> expr = |alpha, beta, sel, exprs| | ||
| sel * (compress_columns(alpha, exprs) + beta - 1) + 1; |
There was a problem hiding this comment.
Suggested change
| sel * (compress_columns(alpha, exprs) + beta - 1) + 1; | |
| sel * (beta - compress_columns(alpha, exprs) - 1) + 1; |
I think both is sound, but this makes it clear we're evaluating
|
Wondering if this PR is superseded, but it adds the |
|
is it worth it to revive it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.