Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnaryExpression struct in Expressions #1352

Merged
merged 8 commits into from
May 22, 2024
Merged

UnaryExpression struct in Expressions #1352

merged 8 commits into from
May 22, 2024

Conversation

gzanitti
Copy link
Contributor

@gzanitti gzanitti commented May 6, 2024

This PR is part of issue #1345.
In particular, it adds the struct UnaryOperation to Expressions to homogenise the structure before including source references.

@gzanitti gzanitti marked this pull request as ready for review May 6, 2024 17:19
@gzanitti gzanitti requested a review from chriseth May 6, 2024 17:19
This was referenced May 7, 2024
Merged
Closed
chriseth
chriseth reviewed May 10, 2024
View reviewed changes
ast/src/parsed/display.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff previously approved these changes May 17, 2024
View reviewed changes
chriseth
chriseth previously approved these changes May 21, 2024
View reviewed changes
@gzanitti gzanitti dismissed stale reviews from chriseth and Schaeff via 240ab91 May 21, 2024 19:50
@gzanitti gzanitti requested a review from chriseth May 21, 2024 20:21
@chriseth chriseth added this pull request to the merge queue May 22, 2024
Merged via the queue into powdr-labs:main with commit 98da495 May 22, 2024
6 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2024
@gzanitti @chriseth
SourceRef in expressions (#1357)
0d9669e 
This PR solves issue #1293.

Includes PRs that modify some Expression in order to match fields. It is
recommended to review/merge those first:
- #1351 
- #1352
- #1353
- #1354
- #1355


All comments are welcome :)

---------

Co-authored-by: chriseth <chris@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

@Schaeff Schaeff Schaeff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gzanitti @Schaeff @chriseth