Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchExpression struct in Expressions #1354

Merged
merged 16 commits into from
May 22, 2024

Conversation

gzanitti
Copy link
Contributor

@gzanitti gzanitti commented May 6, 2024

This PR is part of issue #1345.
In particular, it adds the struct MatchExpression to Expressions to homogenise the structure before including source references.

@gzanitti gzanitti marked this pull request as ready for review May 6, 2024 20:53
@gzanitti gzanitti requested a review from chriseth May 6, 2024 23:45
ast/src/parsed/mod.rs Outdated Show resolved Hide resolved
ast/src/parsed/mod.rs Outdated Show resolved Hide resolved
ast/src/parsed/mod.rs Outdated Show resolved Hide resolved
chriseth
chriseth previously approved these changes May 21, 2024
@chriseth chriseth added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 21, 2024
chriseth
chriseth previously approved these changes May 22, 2024
@chriseth chriseth dismissed their stale review May 22, 2024 08:52

seems to contain other changes

@chriseth
Copy link
Member

There seem to be a lot of changes concerning UnaryOperation. let's wait for that one to be merged.

@gzanitti gzanitti requested a review from chriseth May 22, 2024 14:13
@chriseth chriseth added this pull request to the merge queue May 22, 2024
Merged via the queue into powdr-labs:main with commit c10ffb1 May 22, 2024
6 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2024
This PR solves issue #1293.

Includes PRs that modify some Expression in order to match fields. It is
recommended to review/merge those first:
- #1351 
- #1352
- #1353
- #1354
- #1355


All comments are welcome :)

---------

Co-authored-by: chriseth <chris@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants