Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Force shutdown routine to be run #915

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

georgwiese
Copy link
Collaborator

@georgwiese georgwiese commented Jan 17, 2024

Hacky version of (hopefully) sound continuations (#814). These added constraints should force the prover to set the jump_to_shutdown_routine flag correctly, e.g.:

  • It should not be set while still in the bootloader
  • After the bootloader, it should be set exactly once
  • The shutdown routine should have enough time to actually finish

This is only a hacky implementation, because we could not have added these constraints already. For example:

  • The PC update rule is replaced
  • Accesses the instr_jump_to_bootloader_input flag to find out if the bootloader has finished
  • Accesses the pc_update intermediate polynomial to make sure that the final PC is exposed correctly in the bootloader inputs.

To test:
PILCOM=$(pwd)/pilcom/ cargo test --all --all-features --profile pr-tests -- --ignored --exact test_many_chunks_memory

@georgwiese georgwiese force-pushed the shutdown-routine-prototype2 branch 3 times, most recently from d80b2d7 to 825cc21 Compare January 25, 2024 13:41
@georgwiese georgwiese force-pushed the shutdown-routine-prototype2 branch 2 times, most recently from 4a15ac8 to b1a4959 Compare January 25, 2024 13:55
@georgwiese georgwiese changed the base branch from shutdown-routine-asm to jump-to-shutdown-routine January 25, 2024 13:55
@georgwiese georgwiese changed the title [WIP] Shutdown routine prototype (2) [Prototype] Force shutdown routine to be run Jan 25, 2024
@georgwiese georgwiese force-pushed the shutdown-routine-prototype2 branch 2 times, most recently from a56a93f to 042cd2d Compare January 30, 2024 12:57
@georgwiese georgwiese force-pushed the jump-to-shutdown-routine branch 3 times, most recently from dfeb95f to 527831f Compare January 31, 2024 12:02
Base automatically changed from jump-to-shutdown-routine to main January 31, 2024 15:42
@leonardoalt
Copy link
Member

@georgwiese just curious: can #1221 be used for the pc stuff here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants