Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor child masking bounds handling #6266

Merged
merged 7 commits into from May 9, 2024

Conversation

EVAST9919
Copy link
Contributor

@EVAST9919 EVAST9919 commented Apr 23, 2024

Split from #6261

Original pr has too much stuff changed at once, so a bit more lenient approach feels way better.
Performance shouldn't differ much (if at all).

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 8, 2024
@EVAST9919
Copy link
Contributor Author

I believe that this assertion should pass.

The test you've provided failed because as you said children weren't aware of the masking changes in the sub-tree. Invalidating DrawInfo did the trick, and it shouldn't affect performance since there are little to no use cases of frequent masking toggling.

@smoogipoo
Copy link
Contributor

smoogipoo commented May 9, 2024

Looks okay now, can't think of anything else that'll break. The DrawNode invalidation is probably not required but I can understand why you've added it (it changes a DrawNode flag). Not a big deal in any case.

@smoogipoo smoogipoo merged commit bf44358 into ppy:master May 9, 2024
21 checks passed
@EVAST9919 EVAST9919 deleted the masking-bounds branch May 9, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants