Switch Linux scripts to python3 and Gtk 3 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are also DeprecationWarnings for lines 99 and 100 as Gdk.Screen.width and Gdk.Screen.height are deprecated. Changing this might change how prey-lock deals with multiple displays, so I din't touch it.
There's an existing issue with text overflowing on the new account screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 is no longer supported (#453), and Gtk 2 is not recommended. I only have a Linux machine, so I only updated the Linux scripts and not the Mac ones.
I haven't tested the minimum Python 3 version, but I would expect the scripts to work on Python 3.5 and later. The minimum Gtk version is 3.20. This would mean Debian Jessie and earlier are not supported.
The updated code emits some DeprecationWarnings. These are mostly a consequence of Gtk 3.0's insistence on CSS-defined styling instead of styling defined in code. There is also a DeprecationWarning relating to
prey-lock's use ofGdk.Screen.width. That has implications for multiple-screen setups, which I can't test right now, so it's unchanged.I found two bugs while testing that existed with python 2 and 3. Exiting out of an alert with a reply is not reliable, and there is some overlapping text in
prey-config.py.