-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dbgenerated): Fix wording and details around dbgenerated and default #5007
Conversation
…ay `dbgenerated(...)` to make clear it needs a parameter
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links
(Note that links will only be valid after Vercel preview deploy succeeded) |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
dbgenerated()
to always say dbgenerated(...)
to make clear it needs a parameterdbgenerated()
is not allowed any more
content/400-reference/200-api-reference/100-prisma-schema-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/100-prisma-schema-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/100-prisma-schema-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/100-prisma-schema-reference.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I made suggestions to change the sentence "annotated with a
@default
valueattribute" because we're annotating fields with attributes, not values - do we know which release we need to fill in where I left the other comment? if no, maybe just drop that bullet altogether for now so that we can merge this one?
Co-authored-by: Nikolas <nikolas.burk@gmail.com>
content/400-reference/200-api-reference/100-prisma-schema-reference.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, let's merge @janpio ?
dbgenerated()
is not allowed any more
Yes, please add a link to the PR where you moved the future upcoming breaking change though. |
@janpio at one point it looks like this was ready for merge, but the linked issue prisma/prisma#19313 is still not closed. Should we close this PR pending work on that issue? |
I think the dependency on prisma/prisma#19313 has been mostly removed, the text does not explicitly say that |
Deploying docs with Cloudflare Pages
|
Absolute URL checkNo absolute URLs to prisma.io/docs found. |
@janpio conflicts resolved. Let me know if it still matches your expectations. |
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Yes looks good I think. |
Includes switch of
dbgenerated()
to always saydbgenerated(...)
to make clear it prefers a parameter.