Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbgenerated): Fix wording and details around dbgenerated and default #5007

Merged
merged 14 commits into from
Jun 10, 2024

Conversation

janpio
Copy link
Member

@janpio janpio commented Jul 5, 2023

Includes switch of dbgenerated() to always say dbgenerated(...) to make clear it prefers a parameter.

…ay `dbgenerated(...)` to make clear it needs a parameter
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 9:04am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@janpio janpio changed the title fix(dbgenerated): Switch documentation of dbgenerated() to always say dbgenerated(...) to make clear it needs a parameter fix(dbgenerated): Document that dbgenerated() is not allowed any more Jul 5, 2023
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I made suggestions to change the sentence "annotated with a @default value attribute" because we're annotating fields with attributes, not values
  • do we know which release we need to fill in where I left the other comment? if no, maybe just drop that bullet altogether for now so that we can merge this one?

@janpio

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
@nikolasburk nikolasburk self-requested a review November 24, 2023 08:55
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, let's merge @janpio ?

@janpio janpio changed the title fix(dbgenerated): Document that dbgenerated() is not allowed any more fix(dbgenerated): Fix wording and details around dbgenerated and default Nov 24, 2023
@janpio janpio marked this pull request as ready for review November 24, 2023 09:04
@janpio
Copy link
Member Author

janpio commented Nov 24, 2023

Yes, please add a link to the PR where you moved the future upcoming breaking change though.

@jharrell
Copy link
Member

@janpio at one point it looks like this was ready for merge, but the linked issue prisma/prisma#19313 is still not closed. Should we close this PR pending work on that issue?

@janpio
Copy link
Member Author

janpio commented Jun 10, 2024

I think the dependency on prisma/prisma#19313 has been mostly removed, the text does not explicitly say that dbgenerated() is not possible (which it currently still is). So maybe this can be un-conflicted and be merged already, and for prisma/prisma#19313 we would need to create a new docs PR that adds that dbgenerated() is explicitly not valid?

Copy link

cloudflare-pages bot commented Jun 10, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14d5e5b
Status: ✅  Deploy successful!
Preview URL: https://dcfa4e33.docs-51g.pages.dev
Branch Preview URL: https://janpio-dbgenerated.docs-51g.pages.dev

View logs

Copy link
Contributor

Absolute URL check

No absolute URLs to prisma.io/docs found.

@jharrell
Copy link
Member

@janpio conflicts resolved. Let me know if it still matches your expectations.

@jharrell jharrell self-requested a review June 10, 2024 16:03
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@janpio
Copy link
Member Author

janpio commented Jun 10, 2024

Yes looks good I think.

@jharrell jharrell merged commit d51c59e into main Jun 10, 2024
10 checks passed
@jharrell jharrell deleted the janpio/dbgenerated branch June 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants