Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix internal links routing #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix internal links routing #49

wants to merge 1 commit into from

Conversation

prastut
Copy link
Contributor

@prastut prastut commented Feb 27, 2016

Documenting PR:

Problem: Running Jekyll serve disturbs some internal URLS from the assets folder, thereby making the URL's unreadable on Jekyll server as it can't find the files.

Eg:

  • Before running Jekyll serve, the original URL was this:

    <link href="/assets/themes/twitter/bootstrap/css/bootstrap.min.css" rel="stylesheet">
  • After running Jekyll serve, the URL changed to this:
    <link href="/assets/themes/twitter//bootstrap/css/bootstrap.min.css" rel="stylesheet">

This bug was found in the routing of the links. This PR resolves that.

@smcgregor
Copy link
Member

@prastut Can you describe the changes you are proposing, and why you are proposing them? I know you were discussing this on IRC, but we need to be formal in the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants