Fixes dual-side lighting #2644
Merged
Fixes dual-side lighting #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2014, fixes #2018. Lighting is computed twice in vertex shader and one of the two colors is chosen in fragment shader, which has information whether the fragment is facing front or back. Polygons are expected to be specified by user in CW order in left handed coordinate system (X extends to the right, Y extends downwards, Z extends towards the camera). Normals are expected to extend from front faces.
Bonus: more robust arc implementation which also displays CHORD and OPEN correctly. Distribustion of light on the surface might not be perfect since for these two modes the center of triangle fan is moved to the side, but it is not very noticeablce.