Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InputfieldSelector.js to work with repeaters #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elabx
Copy link

@elabx elabx commented Feb 6, 2024

Inputfield selector doesn't work if loaded through a repeater.

Inputfield selector doesn't work if loaded through a repeater.
@ryancramerdesign
Copy link
Member

Thanks for the PR @elabx this seems like a good idea. But having a closer look, I realized we probably need to refactor the InputfieldSelector.js init() method completely in order for this to work properly. As it is, I think we'd end up with double attached events for every reload event. So I need to split the init() method into two parts, one that attaches the document events, and the other that applies just to .InputfieldSelector elements that have not yet been initialized. I'll revisit this soon.

@elabx
Copy link
Author

elabx commented Feb 15, 2024

You are super right, just saw the bugs in a bunch of my sites just today. Maybe you have a reference at hand from another Inputfield on how to implement this? Maybe InputfieldPageAutocomplete.js? If not, that's ok too, I've got enough clues on your reply! Appreciate your time and attention on this matter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants