New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Mesos provider to run before releasing new version of ADB #31
Conversation
Add info that only libvirt is support ATM. |
pass | ||
|
||
self.assertIn('"appId":"/helloapache"', out) | ||
self.assertIn('"appId":"/helloapache"', out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to check if apache inside container is really responding.
curl localhost:80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadel can you suggest a way to do that? All I can think of is to parse the json output we get from the Marathon API and then hit the port on which Marathon has started the container. If we want to hit port 80, we'll need to curl the IP address the container it gets from Docker.
In both the cases, I'd suggest implementing it as another feature in order to get this tests merged and useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure this can be added later. I can help with that. I'll look into it.
7807805
to
d8f2d2c
Compare
6845c25
to
e387bc6
Compare
@navidshaikh I've incorporated the changes suggested or replied back where I haven't made changes. Before the merge, just like last time, we'll need to remove references to my forked repo |
e387bc6
to
880ae8b
Compare
@dharmit : Looks good. Lets remove the references to forked repo and we merge it? |
Sorry, the reference changing and few other things that got added to adb-ci-ansible repo broke this stuff. I'll try to look at this over weekend. |
bb189e7
to
931e598
Compare
This job can be accessed on CentOS CI UI.
This is a parameterized build which asks for a URL before starting the build. The URL needs to be a valid URL to the Vagrant box. Once you provide a valid URL, flow of the job is like below:
libvirt
provider.~/adb
.~/adb-tests
.~/adb/components/centos/centos-mesos-marathon-singlenode-setup/
is modified to refer to the newly built box instead of defaultprojectatomic/adb
.projectatomic/helloapache
with the provider Mesos and hit Marathon API to check if the app started up properly.@navidshaikh ping, once again we need to remove references to my fork before the final merge.