Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Mesos provider to run before releasing new version of ADB #31

Closed
wants to merge 1 commit into from

Conversation

dharmit
Copy link
Contributor

@dharmit dharmit commented Apr 29, 2016

This job can be accessed on CentOS CI UI.

This is a parameterized build which asks for a URL before starting the build. The URL needs to be a valid URL to the Vagrant box. Once you provide a valid URL, flow of the job is like below:

  1. New Vagrant box is pulled for libvirt provider.
  2. Atomic Developer Bundle repo is cloned to ~/adb.
  3. My fork of ADB Tests repo is cloned to ~/adb-tests.
  4. Vagrantfile for Mesos provider under ~/adb/components/centos/centos-mesos-marathon-singlenode-setup/ is modified to refer to the newly built box instead of default projectatomic/adb.
  5. New Vagrant box is boot up.
  6. We clone atomicapp inside the box, start an atomicapp projectatomic/helloapache with the provider Mesos and hit Marathon API to check if the app started up properly.
  7. Vagrant box is destroyed before exiting the tests.

@navidshaikh ping, once again we need to remove references to my fork before the final merge.

@dharmit
Copy link
Contributor Author

dharmit commented May 18, 2016

Add info that only libvirt is support ATM.

pass

self.assertIn('"appId":"/helloapache"', out)
self.assertIn('"appId":"/helloapache"', out)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to check if apache inside container is really responding.

curl localhost:80

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel can you suggest a way to do that? All I can think of is to parse the json output we get from the Marathon API and then hit the port on which Marathon has started the container. If we want to hit port 80, we'll need to curl the IP address the container it gets from Docker.

In both the cases, I'd suggest implementing it as another feature in order to get this tests merged and useful.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure this can be added later. I can help with that. I'll look into it.

@dharmit dharmit force-pushed the adb-release-mesos branch 3 times, most recently from 6845c25 to e387bc6 Compare June 7, 2016 11:10
@dharmit
Copy link
Contributor Author

dharmit commented Jun 7, 2016

@navidshaikh I've incorporated the changes suggested or replied back where I haven't made changes. Before the merge, just like last time, we'll need to remove references to my forked repo

@navidshaikh
Copy link
Collaborator

@dharmit : Looks good. Lets remove the references to forked repo and we merge it?

@dharmit
Copy link
Contributor Author

dharmit commented Jun 10, 2016

Sorry, the reference changing and few other things that got added to adb-ci-ansible repo broke this stuff. I'll try to look at this over weekend.

@cdrage cdrage force-pushed the master branch 3 times, most recently from bb189e7 to 931e598 Compare July 15, 2016 16:37
@dharmit dharmit closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants