Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role=region and aria-controls to the FacetFieldComponent #3129

Merged
merged 1 commit into from Jan 25, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 19, 2024

This follows the example of https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ for setting the aria properties for an accordion type widget

Fixes #3119

This follows the example of https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ for setting the aria properties for an accordion type widget
@marlo-longley marlo-longley merged commit 4983983 into main Jan 25, 2024
13 checks passed
@marlo-longley marlo-longley deleted the aria-accordion branch January 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-labelledby on a div without a role is not useful
2 participants