Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation: External Processing support #5867

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

izturn
Copy link
Member

@izturn izturn commented Oct 19, 2023

Signed-off-by: Gang Liu gang.liu@daocloud.io

Implementation proposal to address #5123

Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn requested a review from a team as a code owner October 19, 2023 03:44
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team October 19, 2023 03:44
@izturn izturn self-assigned this Oct 19, 2023
@izturn izturn added area/infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note/infra An infrastructure update for the release notes. labels Oct 19, 2023
@izturn
Copy link
Member Author

izturn commented Oct 19, 2023

Due to the current proposal status, relevant unit tests have not been added yet

Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 18.97233% with 205 lines in your changes are missing coverage. Please review.

Project coverage is 80.61%. Comparing base (6558591) to head (8a321c1).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5867      +/-   ##
==========================================
- Coverage   81.62%   80.61%   -1.02%     
==========================================
  Files         133      133              
  Lines       15852    16083     +231     
==========================================
+ Hits        12939    12965      +26     
- Misses       2619     2811     +192     
- Partials      294      307      +13     
Files Coverage Δ
internal/dag/dag.go 98.44% <ø> (ø)
internal/sorter/sorter.go 100.00% <ø> (ø)
pkg/config/parameters.go 88.03% <ø> (ø)
internal/fixture/httpproxy.go 82.92% <0.00%> (-8.97%) ⬇️
internal/xdscache/v3/listener.go 89.14% <37.50%> (-2.87%) ⬇️
cmd/contour/servecontext.go 82.47% <11.11%> (-3.48%) ⬇️
cmd/contour/serve.go 22.22% <5.55%> (-0.45%) ⬇️
internal/envoy/v3/route.go 75.44% <0.00%> (-4.43%) ⬇️
internal/envoy/v3/listener.go 90.79% <6.38%> (-7.66%) ⬇️
internal/dag/httpproxy_processor.go 85.89% <31.85%> (-5.52%) ⬇️

Copy link

github-actions bot commented Nov 3, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Makefile Outdated Show resolved Hide resolved
apis/projectcontour/v1/helpers.go Outdated Show resolved Hide resolved
}

// GRPCService configure the gRPC service that the filter will communicate with.
type GRPCService struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type GRPCService struct {
type ExtProcServer struct {

keeps it uniform with AuthorizationServer

hack/generate-api-docs.sh Outdated Show resolved Hide resolved
hack/generate-crd-deepcopy.sh Outdated Show resolved Hide resolved
internal/dag/dag.go Show resolved Hide resolved
apis/projectcontour/v1/httpproxy.go Show resolved Hide resolved
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Signed-off-by: gang.liu <gang.liu@daocloud.io>
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2024
@izturn izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2024
@izturn
Copy link
Member Author

izturn commented Apr 28, 2024

ping @clayton-gonsalves

Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/infra An infrastructure update for the release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants