Extract tools/helper programs into hack module #6154
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
force-pushed
the
extract-hack-module
branch
from
18a1ae7
to
61e45b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6154 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 133 133
Lines 15772 15772
=======================================
Hits 12828 12828
Misses 2650 2650
Partials 294 294 |
|
TODOs:
|
sunjayBhatia
force-pushed
the
extract-hack-module
branch
from
61e45b9
to
b9e7ac5
Compare
- update .gitignore for updated golang recommendations - update references to moved scripts - add make target - update dependabot config Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
extract-hack-module
branch
from
b9e7ac5
to
85a28d0
Compare
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
sunjayBhatia
removed
the
lifecycle/stale
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully reduce some of the top level module required packages for things that arent actually used by contour, just in tools
Means local dev environments should include a go.work file, set up with
go work init && go work use . && go work use ./hack