test/e2e: verify resource status upon creation #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
added
the
release-note/none-required
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
davinci26
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6347 +/- ##
=======================================
Coverage 81.59% 81.59%
=======================================
Files 133 133
Lines 15861 15861
=======================================
Hits 12941 12941
Misses 2624 2624
Partials 296 296 |
|
Considering nearly every invocation of the "CreateAndWaitFor" methods ignore the first returned argument, I'm going to look at dropping it from the API. Tests that need to re-fetch the Kube resource from the apiserver after creation can do it explicitly. Means all of these can become one-liners. |
lubronzhan
reviewed
Apr 16, 2024
| @@ -668,17 +658,16 @@ var _ = Describe("Gateway provisioner", func() { | |||
| } else { | |||
| // Root proxy in non-watched namespace should fail | |||
| By(fmt.Sprintf("Expect namespace %s not to be watched by contour", t.namespace)) | |||
| hr, ok := f.CreateHTTPRouteAndWaitFor(route, e2e.HTTPRouteIgnoredByContour) | |||
| require.True(f.T(), ok, fmt.Sprintf("httproute's is %v", hr)) | |||
There was a problem hiding this comment.
I did use it here for debugging purpose in case it fails.
But yeah it's doable just to add a function to get the resource, since most of the code base doesn't use this.
Adds checks to verify resources are eventually created with the expected status, where missing. Without these checks, it's unknown whether the "CreateAndWaitFor" method was successful or timed out waiting for the desired condition. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Virtually every invocation of these methods ignores the first return arg, so drop it from the methods. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
force-pushed
the
pr-e2e-verify-status
branch
from
cbdd0f4
to
492416e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to verify resources are eventually
created with the expected status, where missing.
Without these checks, it's unknown whether the
"CreateAndWaitFor" method was successful or timed
out waiting for the desired condition.