Added support for implicit proxy configurations #289
Conversation
When a new http.Client is being created from HTTPClientConfig, implicit proxy configurations are not supported. This commit adds support to pick up proxy configurations from the environment when the consuming application does not specify any. Signed-off-by: Chaitanya Munukutla <chaitanya.m61292@gmail.com>
|
Fixes #288 |
|
Thank you. We prefer to have proxies explicitly set in the configuration. Additionally, this is a huge breaking change as any people might have proxies to go to the internet and not expect prometheus to use them for scraping etc. |
|
@roidelapluie then can you suggest how to exclude proxies for Prometheus remote reads and remote writes? Is it better to have application level exclusion policies instead of having it in common? |
|
You should only set a proxy_url: in the prometheus configuration where you need it. |
|
Our weird case is that even if we don't need it, it's picking it up from the environment variables. In fact, we have not set the proxy configuration in Prometheus YML at all, but it's picking up proxy for EC2 SD (intended) and remote writes (unintended). Any clue why this might happen? |
|
I can not reproduce this locally. Which env variables are you using exactly? |
|
closing as per prometheus/prometheus#8720 (comment) |
When a new http.Client is being created from HTTPClientConfig, implicit proxy configurations are not supported.
This pull request adds support to pick up proxy configurations from the environment when the consuming application does not specify any.