Skip to content

Commit

Permalink
Stop appending &_= to the parameters for non-GET Ajax requests in S…
Browse files Browse the repository at this point in the history
…afari. We no longer support any version of Safari for which this is necessary. [#327 state:resolved] (John-David Dalton, Andrew Dupont)
  • Loading branch information
savetheclocktower committed Oct 19, 2010
1 parent ccb929d commit 704aa40
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG
@@ -1,3 +1,5 @@
* Stop appending `&_=` to the parameters for non-GET Ajax requests in Safari. We no longer support any version of Safari for which this is necessary. [#327 state:resolved] (John-David Dalton, Andrew Dupont)

* Ensure `Form.focusFirstElement` doesn't raise an exception on forms with no fields. [#341 state:resolved] (achernin, Andrew Dupont)

* Define a `relatedTarget` property on extended mouseenter/mouseleave events in IE's legacy event system. [#708 state:resolved] (Walter Smith, Tobie Langel, Andrew Dupont)
Expand Down
7 changes: 2 additions & 5 deletions src/ajax/request.js
Expand Up @@ -189,12 +189,9 @@ Ajax.Request = Class.create(Ajax.Base, {
this.method = 'post';
}

if (params) {
if (params && this.method === 'get') {
// when GET, append parameters to URL
if (this.method == 'get')
this.url += (this.url.include('?') ? '&' : '?') + params;
else if (/Konqueror|Safari|KHTML/.test(navigator.userAgent))
params += '&_=';
this.url += (this.url.include('?') ? '&' : '?') + params;
}

this.parameters = params.toQueryParams();
Expand Down

0 comments on commit 704aa40

Please sign in to comment.