Skip to content

Commit

Permalink
deprecation extension: Modified deprecation notice for Array#reduce.
Browse files Browse the repository at this point in the history
  • Loading branch information
tobie committed Mar 23, 2009
1 parent f44d050 commit b8635eb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion ext/update_helper/prototype_update_helper.html
Expand Up @@ -268,7 +268,8 @@ <h1>Prototype Unit test file</h1>

a.reduce(function(){});
this.assertErrorNotified('Array#reduce is no longer supported.\n' +
'This is due to an infortunate naming collision with Mozilla\'s soon to be standardized (as of EcmaScript 3.1) Array#reduce implementation (whhich is similar to Prototype\'s Array#inject).')
'This is due to an infortunate naming collision with Mozilla\'s own implementation of Array#reduce which differs completely from Prototype\'s implementation (it\'s in fact similar to Prototype\'s Array#inject).\n' +
'Mozilla\'s Array#reduce is already implemented in Firefox 3 (as part of JavaScript 1.8) and is about to be standardized in EcmaScript 3.1.')
},

testClass: function() {
Expand Down
3 changes: 2 additions & 1 deletion ext/update_helper/prototype_update_helper.js
Expand Up @@ -257,7 +257,8 @@ var prototypeUpdateHelper = new UpdateHelper([
methodName: 'reduce',
namespace: Array.prototype,
message: 'Array#reduce is no longer supported.\n' +
'This is due to an infortunate naming collision with Mozilla\'s soon to be standardized (as of EcmaScript 3.1) Array#reduce implementation (whhich is similar to Prototype\'s Array#inject).',
'This is due to an infortunate naming collision with Mozilla\'s own implementation of Array#reduce which differs completely from Prototype\'s implementation (it\'s in fact similar to Prototype\'s Array#inject).\n' +
'Mozilla\'s Array#reduce is already implemented in Firefox 3 (as part of JavaScript 1.8) and is about to be standardized in EcmaScript 3.1.',
type: 'error'
},

Expand Down

1 comment on commit b8635eb

@evansj
Copy link

@evansj evansj commented on b8635eb Mar 24, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely “unfortunate”

Please sign in to comment.