Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #5979 - NULL pointer crash in ModelObject::split() #5991

Closed
wants to merge 1 commit into from
Closed

Fixes issue #5979 - NULL pointer crash in ModelObject::split() #5991

wants to merge 1 commit into from

Commits on Feb 7, 2021

  1. Fixes issue prusa3d#5979 - NULL pointer crash in ModelObject::split() 

    ModelObject::split() expects a non-NULL new_objects vector where it adds pointers to the new models resulting from the split. But in the CLI case the caller does not care about this and passes NULL which causes a crash. To fix the crash we could pass a dummy vector but it turns out that we actually have a use for the results because we should assign a unique name to each new model the same way as the GUI does. These names show up as comments in the gcode so this change makes the gcode produced by the GUI and the CLI more similar and diffable.
    @combolek
    combolek committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    3803fa2 View commit details
    Browse the repository at this point in the history