Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to force all site visitors to login via AAD #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ccardinaux
Copy link

Hi Philippe,

Thanks for the great plugin! Added a new option to force all site visitors to login via Azure before accessing the site. Would appreciate any edits/comments you have.

Thanks,
Charles


$this->register_session();

$current_url = (isset($_SERVER['HTTPS']) ? "https" : "http") . "://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fail if the server is running on a non-standard port... Check this approach https://gist.github.com/leereamsnyder/fac3b9ccb6b99ab14f36

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for the feedback.

Copy link
Contributor

@bradkovach bradkovach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Paging @psignoret for more feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants