Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to retain URL parameters for login redirects #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brm252
Copy link

@brm252 brm252 commented May 29, 2018

No description provided.

@bradkovach
Copy link
Contributor

In order to ensure proper parsing/encoding, I would suspect that another nested http_build_query should be implemented to "carry over" any params in this fashion...

'redirect_uri'  => $settings->redirect_uri
     . $_SERVER['QUERY_STRING']
          ? "?" . http_build_query( $_GET )
          : "",

Overall, I am concerned that adding data to the authorization loop might break something. @psignoret would know more about this.

@psignoret psignoret force-pushed the master branch 2 times, most recently from 0320183 to 37c8428 Compare July 18, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants