Fix serialize method for Rails 7.1.2 compatibility #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhru
changed the title
the-zack-stack
approved these changes
Jan 10, 2024
|
@ur5us can you take a look? |
|
@yhru Initially, I thought that this won’t work with Rails ≤7.0 but it does due to how YAML is chosen as the default fallback prior versions of Rails, s. my comment #382 (comment). However, I was wrong and it totally works as expected so I’m happy to merge your PR. However, could you clean it up before I do so and simply remove the changes to the README as version 2.0.0 is not compatible with Rails 7.1, hence your PR. I suggest to simply remove the last 2 commits. I’ll then update the changelog and do a release. |
ur5us
added a commit
that referenced
this pull request
Feb 14, 2024
Regression introduced in #5012e0d6. This change partially reverts the change such that it works for Rails 6.1/7.0 and 7.1+. In Rails 7.1+ the API for `.serialize` changed. At first using `serialize :parameters, coder: YAML, type: Hash` seems to be backwards compatible with Rails 6.1/7.0 when reading the documentation/code but there’s a subtle difference: when the 2nd positional parameter (denoting the target type) is not provided a default mechanism is used. While the defaults will use `YAML` as the coder the serialization will only occur if the column is not `NULL`. So, without an explicit type parameter `nil`/`NULL` values are not converted to `Hash`. Thus, the explicit type parameter acts as the fallback for the value itself. Fixes #386 #384 #382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
serializemethod for Rails 7.1.2 compatibilityThis commit resolves the
ArgumentError: missing keyword: :coderissue encountered in Rails 7.1.2. It updates theserializemethod inpublic_activitygem to include a default coder, ensuring compatibility with the newer Rails version. This change maintains backward compatibility with earlier versions of Rails.