Wrap errors in _error key #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
force-pushed
the
wrap-error-in-_error-key
branch
from
138d847
to
4cb98d0
Compare
Previously, the task helper would rescue errors in the run method and simply print their hashified version. This caused Bolt to synthesize its own _error object (simply stating the task failed and its exit code) which took precedence over the actual underlying cause. We now properly wrap the result in _error so Bolt knows that it should display that information to the user. Porting over the changes from puppetlabs/puppetlabs-ruby_task_helper#5
donoghuc
force-pushed
the
wrap-error-in-_error-key
branch
from
4cb98d0
to
9cc12a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the task helper would rescue errors in the run method and
simply print their hashified version. This caused Bolt to synthesize its own
_error object (simply stating the task failed and its exit code) which
took precedence over the actual underlying cause.
We now properly wrap the result in _error so Bolt knows that it should
display that information to the user.
Porting over the changes from puppetlabs/puppetlabs-ruby_task_helper#5