Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax tensorflow version limit #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Relax tensorflow version limit #389

wants to merge 1 commit into from

Conversation

kbattocchi
Copy link
Collaborator

No description provided.

@kbattocchi kbattocchi force-pushed the kebatt/relaxDeps branch 2 times, most recently from 40084d7 to f6cac43 Compare March 3, 2021 17:25
@akelleh
Copy link

akelleh commented Mar 16, 2021

@kbattocchi Looks like this might fix the DeepIV implementation! need a hand pushing it over the finish line?

@kbattocchi
Copy link
Collaborator Author

@akelleh Yes, that would be great! Thanks for the offer.

@akelleh
Copy link

akelleh commented Mar 18, 2021

I'll make some time this weekend, if you don't get to it before me!

@akelleh
Copy link

akelleh commented Mar 20, 2021

@akelleh Yes, that would be great! Thanks for the offer.

Having some trouble even getting tests running... Following the build instructions on the main page in a new virtualenv (python setup.py develop with an updated setuptools), python setup.py pytest just returns error: invalid command 'pytest'. Any trick to make this work?

@kbattocchi
Copy link
Collaborator Author

Whoops, sorry - looks like we haven't updated the docs after restructuring our package a bit. Try:

pip install -e .[tf,plt]
pip install pytest-runner
python setup.py pytest

@kbattocchi
Copy link
Collaborator Author

You should also set the environment variable PYTEST_ADDOPTS to -m "not (notebook or automl or dml)" so that you're not running a bunch of tests that are unimpacted (and in the case of the notebook and automl tests, have additional dependencies).

@akelleh
Copy link

akelleh commented Mar 20, 2021

You should also set the environment variable PYTEST_ADDOPTS to -m "not (notebook or automl or dml)" so that you're not running a bunch of tests that are unimpacted (and in the case of the notebook and automl tests, have additional dependencies).

Thanks! Will do. I'm taking your PR for a spin now -- so far so good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants