CLI type hinting and minor refactor #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealpinegoat
force-pushed
the
dev_georgeh_type_hinting_python_2_3_jenkinsapi_command_line
branch
4 times, most recently
from
f653345
to
9f41cd3
Compare
Problem: The type hinting for jenkinsapi.command_line is a little lacking. In addition, the use of asserts in non-test code is undesirable. Solution: Introduce type hinting following PEP-484 for straddling code and refactor asserts to use proper conditionals instead.
thealpinegoat
force-pushed
the
dev_georgeh_type_hinting_python_2_3_jenkinsapi_command_line
branch
from
9f41cd3
to
a3f9694
Compare
|
Thanks! |
thealpinegoat
deleted the
dev_georgeh_type_hinting_python_2_3_jenkinsapi_command_line
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The type hinting for jenkinsapi.command_line is a little lacking. In addition, the use of asserts in non-test code is undesirable.
Solution: Introduce type hinting following PEP-484 for straddling code and refactor asserts to use proper conditionals instead.