Follow-up for filename encoding for attachment headers and IE.

pydio · Jun 26, 2015 · c8b12e1 · c8b12e1
1 parent d641046
commit c8b12e1
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/core/src/core/classes/class.HTMLWriter.php b/core/src/core/classes/class.HTMLWriter.php
@@ -148,6 +148,15 @@ public static function javascriptErrorHandler($errorType, $errorMessage)
         die("<script language='javascript'>parent.ajaxplorer.displayMessage('ERROR', '".str_replace("'", "\'", $errorMessage)."');</script>");
     }
 
+    public static function encodeAttachmentName($name){
+        if (preg_match('/ MSIE /',$_SERVER['HTTP_USER_AGENT'])
+            || preg_match('/ WebKit /',$_SERVER['HTTP_USER_AGENT'])
+            || preg_match('/ Trident/',$_SERVER['HTTP_USER_AGENT'])) {
+            $name = str_replace("+", " ", urlencode(SystemTextEncoding::toUTF8($name)));
+        }
+        return $name;
+    }
+
     /**
      * @static
      * @param string $attachmentName
@@ -157,9 +166,7 @@ public static function javascriptErrorHandler($errorType, $errorMessage)
      */
     public static function generateAttachmentsHeader(&$attachmentName, $dataSize, $isFile=true, $gzip=false)
     {
-        if (preg_match('/ MSIE /',$_SERVER['HTTP_USER_AGENT']) || preg_match('/ WebKit /',$_SERVER['HTTP_USER_AGENT']) || preg_match(‘/ Trident/’,$_SERVER[‘HTTP_USER_AGENT’])) {
-             $attachmentName = str_replace("+", " ", urlencode(SystemTextEncoding::toUTF8($attachmentName)));
-         }
+        $attachmentName = self::encodeAttachmentName($attachmentName);
 
         header("Content-Type: application/force-download; name=\"".$attachmentName."\"");
         header("Content-Transfer-Encoding: binary");
@@ -197,6 +204,8 @@ public static function generateAttachmentsHeader(&$attachmentName, $dataSize, $i
 
     public static function generateInlineHeaders($attachName, $fileSize, $mimeType)
     {
+        $attachName = self::encodeAttachmentName($attachName);
+
         //Send headers
         header("Content-Type: " . $mimeType . "; name=\"" . $attachName . "\"");
         header("Content-Disposition: inline; filename=\"" . $attachName . "\"");