Modbus simulator - Added support for additional datatypes #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnl-jseb
force-pushed
the
Extended_datatypes
branch
from
3994d70
to
028cf43
Compare
This update adds native support for some of the most commonly found datatypes in OT systems. This includes support for bitfields, unsigned integers, signed integers, and floating point numbers in multiple word sizes (16 bit, 32 bit and 64 bit). Relevant changes include: A reworked version of simulator.py that relies on struct.unpack, struct.pack, and other native functions to simplifly datatype handling while also incorportating additional checks to ensure the register layout behaves as expected. In order to simplifly future work development, the Bits field has been renamed bitfield16, while also adding support for 32 and 64 bit fields. To help facilitate adoption, several changes have been done to the project files to ensure a smooth transition. This includes: - Updated documentation to reflect new datatypes, including examples. - Updated unit tests, to ensure the code works as expected. - Updated the simulator example to illustrate how the new datatypes can be used - Performed linting on 3.12 Resolves [discussion]: pymodbus-dev#1458 Partially addresses: pymodbus-dev#1284
pnl-jseb
force-pushed
the
Extended_datatypes
branch
2 times, most recently
from
740878b
to
d4146df
Compare
|
This is a very big PR, which will be very hard to review ! splitting it into a number of smaller PRs is needed. This smaller PR are needed not only for review but also for regression testing. The rename of bitfield to bitfield16 ... is illogical since a bit field can be anything from 1bit to 10of thousands, There seems to be a lot of good stuff in this PR, which would be nice to merge in smaller chunks. |
|
Thanks for the feedback, I will do a rollback of the bitfieldXX structures and just keep the bits. As for breaking into smaller chunks, I'm unsure of the best course of action, but I can certainly try to work with you to ensure a smooth merge. |
|
Any progress on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds native support for some of the most commonly found datatypes in OT systems. This includes support for bitfields, unsigned integers, signed integers, and floating point numbers in multiple word sizes (16 bit, 32 bit and 64 bit).
Relevant changes include:
A reworked version of simulator.py that relies on struct.unpack, struct.pack, and other native functions to simplifly datatype handling while also incorportating additional checks to ensure the register layout behaves as expected.
In order to simplifly future work development, the Bits field has been renamed bitfield16, while also adding support for 32 and 64 bit fields. To help facilitate adoption, several changes have been done to the project files to ensure a smooth transition. This includes:
- Updated documentation to reflect new datatypes, including examples.
- Updated unit tests, to ensure the code works as expected.
- Updated the simulator example to illustrate how the new datatypes can be used
Resolves [discussion]: #1458
Partially addresses: #1284